Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-1379: Improve Deprecation thrown check + logic #1381

Conversation

agustingomes
Copy link
Contributor

Unfortunately as part of the previous improvement to determine whether a deprecation is thrown, validating that the deprecation was not thrown ended up not being added explicitly.

In addition, adds the explicit expectation of not throwing the deprecation whenever the --all-or-nothing is not indicated, which was the root cause originating the issue.

Q A
Type bug
BC Break no
Fixed issues #1379

Summary

When the deprecation was added, the check whether the deprecation is NOT triggered was missing. This PR should solve the underlying issue.

Unfortunately as part of the previous improvement to determine whether a deprecation is thrown, validating that the deprecation was not thrown ended up not being added explicitly.

In addition, adds the explicit expectation of not throwing the deprecation whenever the `--all-or-nothing` is not indicated, which was the root cause originating the issue.
@greg0ire greg0ire added this to the 3.7.2 milestone Dec 5, 2023
@greg0ire greg0ire merged commit 47af29e into doctrine:3.7.x Dec 5, 2023
9 checks passed
@greg0ire
Copy link
Member

greg0ire commented Dec 5, 2023

Thanks @agustingomes !

@agustingomes agustingomes deleted the GH-1379/improve-deprecation-expectation-check branch December 5, 2023 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants